forked from open-telemetry/opentelemetry-collector-contrib
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in v0.89.0 #141
Merged
Merged
Merge in v0.89.0 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#27622) **Description:** Remove stale go mod replace for datadog-agent and upgrade to the released version. **Link to tracking Issue:** Fixes open-telemetry#25119.
…try#27634) Remove translation dropping the `opencensus.resourcetype` resource attribute as it's not emitted by k8s receivers anymore. The last one was removed in open-telemetry#27616
**Documentation:** <Describe the documentation added.> Found a typo while reading the transform processor readme.
…open-telemetry#27272) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Added support for Exporter Helper configuration. **Link to tracking Issue:** open-telemetry#24329 **Testing:** <Describe what testing was performed and which tests were added.> Added tests and manually tested with e2e scenarios --------- Co-authored-by: Ramachandran A G <[email protected]> Co-authored-by: Ziqi Zhao <[email protected]> Co-authored-by: Ramachandran A G <[email protected]>
open-telemetry#27485) **Description:** <Describe what has changed.> add k8s.pod.qos_class optional resource attriute **Link to tracking Issue:** <Issue number if applicable> open-telemetry#27483 **Testing:** <Describe what testing was performed and which tests were added.> - updated unit tests **Documentation:** <Describe the documentation added.> - generated
**Description:** This component will export markers to be consumed by the Honeycomb Markers API to highlight user events based initially on preset configurations. **Link to tracking Issue:** open-telemetry#26653 **Testing:** Unit testing for factory and config **Documentation:** README describing component usage --------- Co-authored-by: Tyler Helmuth <[email protected]>
**Description:** It's not obvious from the readme that you won't get all metrics listed in metadata by default. Suggest small doc update to make it clearer. **Link to tracking Issue:** **Testing:** Observed with running collector. **Documentation:** See above. --------- Co-authored-by: Daniel Jaglowski <[email protected]> Co-authored-by: Curtis Robert <[email protected]>
…24183) 2nd step for the deprecation of `container.cpu.percent` According to the deprecation plan in the [docs](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/v0.79.0/receiver/dockerstatsreceiver#transition-to-cpu-utilization-metric-name-aligned-with-opentelemetry-specification), this PR disables the old metric by default, to be released in v0.83.0 tracking issue: open-telemetry#21807 --------- Co-authored-by: Christian <[email protected]>
…pen-telemetry#27646) **Description:** Fix mask when multiple patterns exist With following input: ``` attr: <secret1> <secret2> ``` and config: ``` redaction: blocked_values: - '<secret1>' - '<secret2>' ``` Output before fix: ``` attr: <secret1> **** ``` Output after fix: ``` attr: **** **** ``` **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
GHSA-qppj-fm5r-hxr3 https://github.com/grpc/grpc-go/releases/tag/v1.58.3 --------- Signed-off-by: Pavol Loffay <[email protected]>
Resolves open-telemetry#27640 --------- Co-authored-by: Paulo Janotti <[email protected]>
…pen-telemetry#27459) Description: Exposes bbolt fsync as a configuration option Link to tracking Issue: [20266](open-telemetry#20266) Testing: Manual Testing, Updated unit tests for factory and client Documentation: Added change-log and documentation comments in config.go --------- Co-authored-by: Daniel Jaglowski <[email protected]>
…-telemetry#27658) **Description:** Cache the publisher event to: 1. Avoid logging the same error message every time one event from the given source is logged. 2. Avoid opening and closing the event publisher for every single event. **Link to tracking Issue:** [Item 4 described on the investigation](open-telemetry#21491 (comment)) for issue open-telemetry#21491. **Testing:** * Go tests for `pkg/stanza` and `receiver/windowseventlogreceiver` on Windows box. * Ran the contrib build locally to validate the change. * Can't run the full make locally: misspell is failing on Windows because the command line is too long. **Documentation:** Let me know if changing the severity of the log message requires a changelog update.
**Description:** Adding myself as owner of `windowseventlogreceiver` per invite open-telemetry#27658 (comment) cc @djaglowski
…tings.enabled flag (open-telemetry#27592) **Description:** Previously the remote write exporter would incorrectly retry if `retrySettings.enabled` was set to false. **Testing:** Unit tests
…emetry#27678) **Description:** The `system` detector extracts all the `cpu` info from the system even if you disable the configs and I believe this is where the bug kicks in. Disabling the settings will only stop it from setting the resource attributes. The [library](https://github.com/shirou/gopsutil/blob/v3.23.9/cpu/cpu_windows.go#L113) that we rely on doesn't extract some attributes for Windows OS (in this case, the field `cpu.Model`) and it leaves this field empty. This results in a bug when we try to parse an empty string. The long-term fix will be to extract `cpu.Model` in `gopsutil` upstream library. **Link to tracking Issue:** open-telemetry#27675
Related issue: open-telemetry#20552 Tweak the mock-backend to do following: - Receives data from the receiver. - Returns errors randomly to our receiver, which attempts to resend/drop the data. This is helpful when we're required to test random behaviors of the collector and ensure reliable data delivery. This is my initial PR to expand the testbed. This will help my further efforts to expand the testbed. Myself and @omrozowicz-splunk plan on adding `sending_queue` support to the testbed and expanding the testing capabilities. --------- Co-authored-by: Daniel Jaglowski <[email protected]>
…elemetry#27464) **Description:** Adding integration tests for syslog exporter (and syslog receiver) and fixing bugs which has been found during the process **Link to tracking Issue:** open-telemetry#21245 **Testing:** Integration tests and more unit tests **Documentation:** N/A --------- Signed-off-by: Dominik Rosiek <[email protected]> Co-authored-by: Daniel Jaglowski <[email protected]>
…try#27684) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Logs and traces are not supported telemetry types for the file receiver, and the collector will fail to start if it the receiver is in included in a pipeline of either of these types. This change is to correct the README to properly reflect this. **Link to tracking Issue:** <Issue number if applicable> Resolves open-telemetry#27682 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
) running `make gengithub` or `make update-codeowners` with an incorrect token or without setting the token throws the same following error: ```https://api.github.com/orgs/open-telemetry/members?per_page=50: 401 Bad credentials []``` It makes sense to throw an error if the user has forgotten to set the GITHUB_TOKEN variable and it also distinguishes between the two cases (incorrect token and token not set)
This has been causing ambiguous imports all over the place for some time. Signed-off-by: Alex Boten <[email protected]>
Refactored parts of the Splunk Enterprise receiver to better leverage the pre-existing otel SDK. This PR also updates the README to be a more informative document. [27026](open-telemetry#27026) Unit testing is included and updated to accommodate the new refactor.
…g parameter (open-telemetry#27611) **Description:** The max_connections config setting were deprecated with open-telemetry#16837 and open-telemetry#16838. It has been 10 months since these changes have been made and it is time to remove this configuration setting altogether. **Link to tracking Issue:** open-telemetry#27610
…elemetry#27612) **Description:** The current SignalFx exporter maps to a static user agent string "OpenTelemetry-Collector SignalFx Exporter/v0.0.1". This PR changes the version to match the build info version. **Link to tracking Issue:** Fixes open-telemetry#16841
Fixes some incorrect wording in the contributing documentation
Reuse the byte buffer used when encoding metrics to HEC events JSON.
…ry#27725) Bump github.com/DataDog/datadog-api-client-go/v2 from 2.17.0 to 2.18.0 in /exporter/datadogexporter Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp from 1.19.1 to 1.20.0 in /exporter/datadogexporter Bump github.com/aliyun/aliyun-log-go-sdk from 0.1.60 to 0.1.63 in /exporter/alibabacloudlogserviceexporter Bump github.com/aws/aws-sdk-go from 1.45.24 to 1.45.25 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.45.24 to 1.45.25 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.45.24 to 1.45.25 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.45.24 to 1.45.25 in /processor/resourcedetectionprocessor Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 in /pkg/translator/opencensus Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 in /processor/resourcedetectionprocessor Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 in /receiver/activedirectorydsreceiver Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 in /receiver/elasticsearchreceiver Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 in /receiver/sqlserverreceiver Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 in /receiver/vcenterreceiver Bump github.com/klauspost/compress from 1.17.0 to 1.17.1 in /exporter/fileexporter Bump github.com/prometheus/prometheus from 0.47.1 to 0.47.2 in /exporter/prometheusexporter Bump github.com/prometheus/prometheus from 0.47.1 to 0.47.2 in /pkg/translator/prometheusremotewrite Bump github.com/prometheus/prometheus from 0.47.1 to 0.47.2 in /testbed Bump google.golang.org/api from 0.146.0 to 0.147.0 in /receiver/googlecloudpubsubreceiver
…ry#27790) Bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.1.0 to 1.2.0 in /receiver/azureblobreceiver Bump github.com/ClickHouse/clickhouse-go/v2 from 2.14.2 to 2.14.3 in /exporter/clickhouseexporter Bump github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp from 1.19.1 to 1.20.0 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.45.24 to 1.45.26 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.45.24 to 1.45.26 in /internal/aws/cwlogs Bump github.com/aws/aws-sdk-go from 1.45.24 to 1.45.26 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.45.24 to 1.45.26 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go from 1.45.25 to 1.45.26 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.45.25 to 1.45.26 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.45.25 to 1.45.26 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.45.25 to 1.45.26 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.45.25 to 1.45.26 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.45.25 to 1.45.26 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.45.25 to 1.45.26 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.45.25 to 1.45.26 in /internal/aws/xray/testdata/sampleapp Bump github.com/aws/aws-sdk-go from 1.45.25 to 1.45.26 in /internal/metadataproviders Bump github.com/aws/aws-sdk-go from 1.45.25 to 1.45.26 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.45.25 to 1.45.26 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.45.25 to 1.45.26 in /receiver/awsecscontainermetricsreceiver Bump github.com/aws/aws-sdk-go-v2 from 1.21.1 to 1.21.2 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2 from 1.21.1 to 1.21.2 in /extension/sigv4authextension Bump github.com/aws/aws-sdk-go-v2/config from 1.18.44 to 1.19.0 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/config from 1.18.44 to 1.19.0 in /extension/sigv4authextension Bump github.com/aws/aws-sdk-go-v2/credentials from 1.13.42 to 1.13.43 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/credentials from 1.13.42 to 1.13.43 in /extension/sigv4authextension Bump github.com/aws/aws-sdk-go-v2/service/kinesis from 1.19.1 to 1.19.2 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/service/sts from 1.23.1 to 1.23.2 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/service/sts from 1.23.1 to 1.23.2 in /extension/sigv4authextension Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.762 to 1.0.766 in /exporter/tencentcloudlogserviceexporter Bump go.mongodb.org/atlas from 0.33.0 to 0.34.0 in /receiver/mongodbatlasreceiver
… nil (open-telemetry#27663) **Description:** Nil is valid value for the attributes in events, spans, resources, and scopes. Lets do not crash when it appears. **Link to tracking Issue:** open-telemetry#27648 **Testing:** I have added unit tests to verify the fix. **Documentation:** <Describe the documentation added.>
…elemetry#29104) **Description:** Replacing inaccurate units for the spark.job.stage.active and spark.job.stage.result metrics for the Apache Spark receiver. **Link to tracking Issue:** [29104](open-telemetry#29104) **Testing:** N/A **Documentation:** Documentation for the metadata.yaml file was updated accordingly.
…n-telemetry#29156) **Description:** This PR updates `github.com/DataDog/datadog-agent/pkg/trace` and `github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes`. This brings in the following PRs: DataDog/opentelemetry-mapping-go#193, DataDog/datadog-agent#20779 which add support for custom container tags (for traces, metrics and logs) via resource attributes prefixed by `datadog.container.tag.*`. This PR also brings a couple other changes for traces which are reflected in the changelog: - Stop extracting container tags from span attributes, but only extract from resource attributes. The semantic conventions we are using to extract the container tags are meant for resource attributes, so we should only check resource attributes. - Stop setting the DD Format container tags as span tags, but only set these in the dedicated container tag (`_dd.container.tag`). We currently set the DD mapped container tags both as span tag, and in the dedicated container tag `_dd.tags.container`. This should only be set in the dedicated container tag. The update to opentelemetry-mapping-go also brings in this change: DataDog/opentelemetry-mapping-go#174, which adds support for `host.cpu.*` attributes.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/github-script](https://togithub.com/actions/github-script) | action | major | `v6` -> `v7` | --- ### Release Notes <details> <summary>actions/github-script (actions/github-script)</summary> ### [`v7`](https://togithub.com/actions/github-script/compare/v6...v7) [Compare Source](https://togithub.com/actions/github-script/compare/v6...v7) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: Alex Boten <[email protected]>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [otel/opentelemetry-collector-contrib](https://togithub.com/open-telemetry/opentelemetry-collector-releases) | minor | `0.86.0` -> `0.88.0` | | prom/prometheus | patch | `v2.47.0` -> `v2.47.2` | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-collector-releases (otel/opentelemetry-collector-contrib)</summary> ### [`v0.88.0`](https://togithub.com/open-telemetry/opentelemetry-collector-releases/releases/tag/v0.88.0) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-collector-releases/compare/v0.87.0...v0.88.0) #### Changelog - [`218f1b9`](https://togithub.com/open-telemetry/opentelemetry-collector-releases/commit/218f1b9) Prepare v0.88.0 release ([#&open-telemetry#8203;419](https://togithub.com/open-telemetry/opentelemetry-collector-releases/issues/419)) - [`9932b7c`](https://togithub.com/open-telemetry/opentelemetry-collector-releases/commit/9932b7c) Revert "Replace datadog-agent dependecy versions ([#&open-telemetry#8203;386](https://togithub.com/open-telemetry/opentelemetry-collector-releases/issues/386))" ([#&open-telemetry#8203;414](https://togithub.com/open-telemetry/opentelemetry-collector-releases/issues/414)) - [`fa0a3a2`](https://togithub.com/open-telemetry/opentelemetry-collector-releases/commit/fa0a3a2) \[chore] bump go versions ([#&open-telemetry#8203;416](https://togithub.com/open-telemetry/opentelemetry-collector-releases/issues/416)) ### [`v0.87.0`](https://togithub.com/open-telemetry/opentelemetry-collector-releases/releases/tag/v0.87.0) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-collector-releases/compare/v0.86.0...v0.87.0) #### Changelog - [`a41e292`](https://togithub.com/open-telemetry/opentelemetry-collector-releases/commit/a41e292) Prepare v0.87.0 release ([#&open-telemetry#8203;415](https://togithub.com/open-telemetry/opentelemetry-collector-releases/issues/415)) - [`7d6fa19`](https://togithub.com/open-telemetry/opentelemetry-collector-releases/commit/7d6fa19) Remove Parquet Exporter from contrib distro ([#&open-telemetry#8203;413](https://togithub.com/open-telemetry/opentelemetry-collector-releases/issues/413)) - [`0373892`](https://togithub.com/open-telemetry/opentelemetry-collector-releases/commit/0373892) Explicitly set 0.0.0.0 on sample configurations ([#&open-telemetry#8203;408](https://togithub.com/open-telemetry/opentelemetry-collector-releases/issues/408)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNy40Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
…etry#26687) **Description:** This test alerts a user if a metric is duplicated across receivers, and instructs the user to add said metric to an allow list if this is intentional. If semantic conventions on the duplicate metric exist, validating is a matter of ensuring they both fulfill semantic intent. For validating duplicate metrics for which there is no semantic conventions, additional discussion is needed with the semantic conventions WG as mentioned in the issue. For the time being, it will be best judgment. **Link to tracking Issue:** open-telemetry#26499
…open-telemetry#29292) **Description:** This PR adds braydonk to the list of active hostmetricsreceiver codeowners. **Link to tracking Issue:** Closes open-telemetry#29287 --------- Signed-off-by: Braydon Kains <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
The following commands were run to prepare this release: - make chlog-update VERSION=v0.89.0 - sed -i.bak s/0.88.0/0.89.0/g versions.yaml - make multimod-prerelease - make multimod-sync
jefchien
force-pushed
the
bump-v0.89.0
branch
8 times, most recently
from
December 4, 2023 20:20
2c0e91c
to
f41c819
Compare
jefchien
force-pushed
the
bump-v0.89.0
branch
2 times, most recently
from
December 4, 2023 23:18
d010b4e
to
6e713b8
Compare
Module set contrib-base, Version v0.89.0
jefchien
force-pushed
the
bump-v0.89.0
branch
from
December 4, 2023 23:35
6e713b8
to
5dc4009
Compare
zhihonl
approved these changes
Dec 5, 2023
adam-mateen
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trusting the tests - approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Merge in changes up to v0.89.0. Resolved merge conflicts.
check-collector-module-version.sh
to not insert the version forreplace
directives.replace
directives forgithub.com/go-kit/kit
andgo.mongodb.org/mongo-driver
due to broken dependenciesSplitFuncBuilder
inpkg/stanza/operator/input/tcp
otelcontribcol
test by changing deprecatedhost.ReportFatalError
toTelemetrySettings.ReportComponentStatus
inreceiver/prometheusreceiver/metrics_receiver.go
exporter/awscloudwatchlogsexporter
exporter/awsemfexporter
exporter/awsxrayexporter
internal/aws
receiver/awscontainerinsightsreceiver
receiver/awsxrayreceiver
override/aws
andextension/awsmiddleware
changes.Link to tracking Issue: N/A
Testing: Ran unit tests for modified receivers/exporters/internal.
Ran integration tests with changes (https://github.com/aws/amazon-cloudwatch-agent/tree/bump-v0.89.0): https://github.com/aws/amazon-cloudwatch-agent/actions/runs/7133797881
Documentation: N/A